New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add opacity to layers and fix transparent blending #3

Merged

tshahab-threekit merged 2 commits into master from layercomp-solid-color

Jun 25, 2024

Collaborator

tshahab-threekit commented Jun 25, 2024 •

edited

Loading

Add opacity to the Layers and shaders
Fix the blending in shader
- use non-premultiplied alpha inputs for blending
- fix math for blending in blend.frag

JIRA ticket: https://threekit.atlassian.net/browse/RDMP-944
Jira Epic: https://threekit.atlassian.net/browse/RDMP-941

tshahab-threekit added 2 commits

June 20, 2024 12:05


          feat: add opacity to layers

cfb15fe


          fix: fix the compositing math in shaders

99446c5

tshahab-threekit requested a review from DanielSturk

June 25, 2024 15:45

DanielSturk approved these changes

View reviewed changes

Collaborator

DanielSturk commented Jun 25, 2024

This adds opacity and fixes a premultiplied alpha issue with blending

tshahab-threekit changed the title ~~Layercomp solid color~~ add opacity to layers and fix transparent blending

tshahab-threekit self-assigned this

tshahab-threekit merged commit 2dd3955 into master

1 of 2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet